config: Parse model from YAML #4826
Conversation
| }) | ||
| } | ||
|
|
||
| file = replaceEnvVars(file) |
There was a problem hiding this comment.
I just want to call out one important thing from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/file-configuration.md#environment-variable-substitution:
It MUST NOT be possible to inject YAML structures by environment variables. For example, references to INVALID_MAP_VALUE environment variable below.
Maybe you will find some code that will help in https://github.com/open-telemetry/opentelemetry-collector.
@codeboten, are you able to provide some guidance?
There was a problem hiding this comment.
Totally agree @pellared, also this does not solve for blocking the key replacement (i.e.${SNEAKY}: "foo") in the spec. I will take a look at both of these cases to see if we can come up with something more useful.
This replaces the last bit of functionality that was opened in open-telemetry#4826 to support env variable replacement. Pulled the envprovider.go code from https://github.com/open-telemetry/opentelemetry-collector/blob/main/confmap/provider/envprovider/provider.go Signed-off-by: Alex Boten <[email protected]>
This replaces the last bit of functionality that was opened in open-telemetry#4826 to support env variable replacement. Pulled the envprovider.go code from https://github.com/open-telemetry/opentelemetry-collector/blob/main/confmap/provider/envprovider/provider.go Signed-off-by: Alex Boten <[email protected]>
Fixes: #4373